[asterisk-dev] [Code Review] Tests for SIP handling of 484 Address Incomplete; Incomplete application

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1417/#review4386
-----------------------------------------------------------



/asterisk/trunk/tests/apps/incomplete/sip_incomplete/configs/ast1/manager.general.conf.inc
<https://reviewboard.asterisk.org/r/1417/#comment8504>

    This file is not needed anymore, and can be removed



/asterisk/trunk/tests/apps/incomplete/sip_incomplete/run-test
<https://reviewboard.asterisk.org/r/1417/#comment8506>

    The 1 can be dropped, it is the default parameter



/asterisk/trunk/tests/apps/incomplete/sip_incomplete/run-test
<https://reviewboard.asterisk.org/r/1417/#comment8511>

    can be removed



/asterisk/trunk/tests/apps/incomplete/sip_incomplete/run-test
<https://reviewboard.asterisk.org/r/1417/#comment8512>

    1 can be removed



/asterisk/trunk/tests/channels/SIP/handle_response_address_incomplete/configs/ast1/manager.general.conf.inc
<https://reviewboard.asterisk.org/r/1417/#comment8505>

    same



/asterisk/trunk/tests/channels/SIP/handle_response_address_incomplete/run-test
<https://reviewboard.asterisk.org/r/1417/#comment8507>

    same



/asterisk/trunk/tests/channels/SIP/handle_response_address_incomplete/run-test
<https://reviewboard.asterisk.org/r/1417/#comment8508>

    exists in TestCase class?



/asterisk/trunk/tests/channels/SIP/handle_response_address_incomplete/run-test
<https://reviewboard.asterisk.org/r/1417/#comment8509>

    Not sure why we are stopping the reactor here.  From the looks of the code asterisk dialplan it is possible for more then one user event to fire?



/asterisk/trunk/tests/channels/SIP/handle_response_address_incomplete/run-test
<https://reviewboard.asterisk.org/r/1417/#comment8510>

    1 can be removed


- Paul


On Sept. 6, 2011, 12:45 p.m., mjordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1417/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2011, 12:45 p.m.)
> 
> 
> Review request for Asterisk Developers, Paul Belanger and rmudgett.
> 
> 
> Summary
> -------
> 
> These tests are for the change under review for ASTERISK-17288 (https://reviewboard.asterisk.org/r/1416/ ).  They test SIP handling of 484 Address Incomplete and the Incomplete application's effect on chan_sip.
> 
> 
> This addresses bug ASTERISK-17288.
>     https://issues.asterisk.org/jira/browse/ASTERISK-17288
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/sipp.py 2057 
>   /asterisk/trunk/tests/apps/incomplete/sip_incomplete/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/incomplete/sip_incomplete/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/apps/incomplete/sip_incomplete/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/incomplete/sip_incomplete/run-test PRE-CREATION 
>   /asterisk/trunk/tests/apps/incomplete/sip_incomplete/sipp/receiver1.xml PRE-CREATION 
>   /asterisk/trunk/tests/apps/incomplete/sip_incomplete/sipp/sender1.xml PRE-CREATION 
>   /asterisk/trunk/tests/apps/incomplete/sip_incomplete/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/incomplete/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/tests.yaml 2057 
>   /asterisk/trunk/tests/channels/SIP/handle_response_address_incomplete/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/handle_response_address_incomplete/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/handle_response_address_incomplete/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/handle_response_address_incomplete/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/handle_response_address_incomplete/sipp/uas1.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/handle_response_address_incomplete/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 2057 
> 
> Diff: https://reviewboard.asterisk.org/r/1417/diff
> 
> 
> Testing
> -------
> 
> Without the patch for ASTERISK-17288, both tests will fail.  The application Incomplete test will fail with a timeout to the t extension, as it received no additional information to dial (and the SIP test will fail as the 484 response will never be forwarded to the dialing party).  The SIP handle response test will fail with a hangup cause of 111.
> 
> 
> Thanks,
> 
> mjordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110920/d0bb4e80/attachment-0001.htm>