[asterisk-dev] [Code Review] Make pbx_start NOT default to s at default if extension not found

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1446/#review4382
-----------------------------------------------------------

Ship it!


This will catch some noobs out that have a [default] with a s that works id recommend adding a comment to the default extensions.conf and add to UPGRADE that this is not valid and recommend that they update there dialplans.

on a side note chan_misdn will work fine as it sends either '' or 's' when no ddi [overlap] is received or immediate is set.

other than this im good with this.

- irroot


On Sept. 19, 2011, 1:57 p.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1446/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2011, 1:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Asterisk today seems to default to exten s at default if extension is not found in function pbx_start in pbx.c. This is not expected behaviour but has been in Asterisk for a long time for some strange function.
> 
> If extension is "", exten "s" should be used, but not otherwise. This patch reverts this behaviour and is proposed for Asterisk 10.
> 
> 
> Diffs
> -----
> 
>   /branches/10/CHANGES 336635 
>   /branches/10/main/pbx.c 336635 
> 
> Diff: https://reviewboard.asterisk.org/r/1446/diff
> 
> 
> Testing
> -------
> 
> WIll come later in my work with fixing the AMI originate action (see rview 1445)
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110920/e3b5653b/attachment.htm>