[asterisk-dev] [Code Review]: Make pbx_start NOT default to s at default if extension not found

[rmudgett]

> On Sept. 19, 2011, 1 p.m., Tilghman Lesher wrote:
> > /branches/10/main/pbx.c, lines 4980-4984
> > <https://reviewboard.asterisk.org/r/1446/diff/1/?file=20747#file20747line4980>
> >
> >     There was another case here at one time, but I don't know if it's been changed or not.  Some PRIs have the capability of starting a call with _no_ extension, and the dialplan can accept this with a blank extension.  If a channel driver does generate a blank extension, then the dialplan should at least attempt to look for a blank extension.
> 
> Olle E Johansson wrote:
>     The SIP channel changes a blank extension to "s". Maybe the PRI/DAHDI should do the same to avoid this code.
> 
> rmudgett wrote:
>     PRI/DAHDI sets the exten to "s" if configured for immediate.  It also does it for a few other conditions.
> 
> Olle E Johansson wrote:
>     Which means that in your view, PRI/DAHDI is not affected by this change, right?
>     
>
> 
> Tilghman Lesher wrote:
>     Okay, then, this is good to go.

Yes.  I don't think it will affect chan_dahdi for any of its sub-technologies: analog, MFC/R2, PRI, and SS7.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1446/#review4365
-----------------------------------------------------------


On Sept. 19, 2011, 12:12 p.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1446/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2011, 12:12 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Asterisk today seems to default to exten s at default if extension is not found in function pbx_start in pbx.c. This is not expected behaviour but has been in Asterisk for a long time for some strange function.
> 
> If extension is "", exten "s" should be used, but not otherwise. This patch reverts this behaviour and is proposed for Asterisk 10.
> 
> 
> Diffs
> -----
> 
>   /branches/10/main/pbx.c 336635 
> 
> Diff: https://reviewboard.asterisk.org/r/1446/diff
> 
> 
> Testing
> -------
> 
> WIll come later in my work with fixing the AMI originate action (see rview 1445)
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110919/4d271798/attachment.htm>