[asterisk-dev] [Code Review]: Add manager event for early media

[Olle E Johansson]

> On Sept. 12, 2011, 9:52 a.m., Matthew Nicholson wrote:
> > /team/oej/bring-in-the-early-media-trunk/apps/app_dial.c, line 801
> > <https://reviewboard.asterisk.org/r/1187/diff/1/?file=16190#file16190line801>
> >
> >     This should be "State: Progress\r\n"

Fixed.


> On Sept. 12, 2011, 9:52 a.m., Matthew Nicholson wrote:
> > /team/oej/bring-in-the-early-media-trunk/main/pbx.c, lines 9053-9057
> > <https://reviewboard.asterisk.org/r/1187/diff/1/?file=16191#file16191line9053>
> >
> >     Whitespace.

Fixed.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1187/#review4300
-----------------------------------------------------------


On Sept. 19, 2011, 6:43 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1187/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2011, 6:43 a.m.)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Add a manager event for early media. Using the existing Newstate event with a "faked" state called "progress". 
> 
> In the long run, this is not the right thing to do, but after discussion with Russell on asterisk-dev it was concluded that it was the easiest way forward.
> 
> 
> This addresses bug 19135.
>     https://issues.asterisk.org/jira/browse/19135
> 
> 
> Diffs
> -----
> 
>   /team/oej/bring-in-the-early-media-trunk/apps/app_dial.c 332755 
>   /team/oej/bring-in-the-early-media-trunk/main/pbx.c 332755 
> 
> Diff: https://reviewboard.asterisk.org/r/1187/diff
> 
> 
> Testing
> -------
> 
> Tested many calls in the 1.4 version of the same patch. 
> 
> One-legged calls using the progress() dialplan app, two legged calls using dial().
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110919/7336dc1a/attachment.htm>