[asterisk-dev] [Code Review] Clean up cel.conf parsing

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1436/#review4324
-----------------------------------------------------------



trunk/cel/cel_manager.c
<https://reviewboard.asterisk.org/r/1436/#comment8416>

    I actually like this logic but decided to remove it for now.  I'm going see about creating an ast_variable_unknown() function for the logging.



trunk/cel/cel_manager.c
<https://reviewboard.asterisk.org/r/1436/#comment8417>

    We load the module, even if we cannot read the configuration file.  This is more inline with how other modules are handled.
    
    We'll just use the default settings.


- Paul


On Sept. 13, 2011, 3:29 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1436/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2011, 3:29 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This includes both [general] and [manager] sections for cel.conf.  We also no longer fail to load the module when the configuration file is missing, it will now use the defaults.
> 
> 
> Diffs
> -----
> 
>   trunk/main/cel.c 335603 
>   trunk/cel/cel_manager.c 335603 
> 
> Diff: https://reviewboard.asterisk.org/r/1436/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110913/46baf76f/attachment-0001.htm>