[asterisk-dev] [Code Review] Set default tonezone for SIP devices

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1429/#review4293
-----------------------------------------------------------



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1429/#comment8378>

    need to release the reference to the ast_tone_zone here if you successfully find one



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1429/#comment8379>

    need to unref here too


- Russell


On Sept. 12, 2011, 7:38 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1429/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2011, 7:38 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When using Asterisk with users in multiple countries it's important to be able to set default tone zone for calls related to the devices. This patch adds a setting called "tonezone" to sip.conf [general] and device sections.
> 
> The reason why I keep the zone as a text string in the peer and dialogs is that indications can change while asterisk is running. I decided to convert it to an actual channel tone zone indication when the channel was created and not keep it in the peer structure.
> 
> 
> This addresses bug ASTERISK-18497.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18497
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 335252 
>   /trunk/channels/sip/include/sip.h 335252 
>   /trunk/configs/sip.conf.sample 335252 
>   /trunk/include/asterisk/indications.h 335252 
> 
> Diff: https://reviewboard.asterisk.org/r/1429/diff
> 
> 
> Testing
> -------
> 
> Locally. Works. 
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110912/778c9e66/attachment.htm>