[asterisk-dev] [Code Review] Iterate though cdr.conf setting

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1426/#review4289
-----------------------------------------------------------

Ship it!


Excellent that someone is picking up on this.

voicemail.conf parsing (app_voicemail.c, load_config()) could use one of these fixes too :) (that one bit me a while ago)

- wdoekes


On Sept. 11, 2011, 2:42 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1426/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2011, 2:42 a.m.)
> 
> 
> Review request for Asterisk Developers and leifmadsen.
> 
> 
> Summary
> -------
> 
> We had some internal discussions this week about how to update configuration files so they worked the same across all modules.  In this example, I've updated cdr.conf to use the same method of iterating over all .conf file variables.  Most people agreed this was the proper way to parse a configuration file.
> 
> If we all agreed, I'd like this method to become the standard way used for parsing configuration file.  Obviously we have some questions that need to be answered, specifically this _may_ break existing configuration files if a duplicate variable is declared later in a .conf file (AKA unused garbage settings).
> 
> FWIW: This is how we do it for manager.conf, features.conf, sip.conf, plus various other modules.
> 
> Thoughts? 
> 
> 
> Diffs
> -----
> 
>   trunk/main/cdr.c 335124 
> 
> Diff: https://reviewboard.asterisk.org/r/1426/diff
> 
> 
> Testing
> -------
> 
> Local asterisk box.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110912/41a97885/attachment.htm>