[asterisk-dev] [Code Review]: No review yet - Set channel variables with setvar= when manager user originates calls

[Leif Madsen]

> On Sept. 7, 2011, 9:48 a.m., Leif Madsen wrote:
> > /trunk/main/manager.c, line 6735
> > <https://reviewboard.asterisk.org/r/1412/diff/1/?file=19959#file19959line6735>
> >
> >     Also don't use:   setvar =>
> >     
> >     in your manager.conf file please. The current usage in sip.conf is:
> >     
> >     setvar=variable=value
> >     
> >     We don't want to confuse people with multiple methods of setting options.
> 
> Tilghman Lesher wrote:
>     They are semantically equivalent, and the syntax provided by oej here is arguably more understandable.

Agreed, but then we should update sip.conf to match so we're consistent across everything. I know they are basically the same thing, but it is confusing for users to have different syntax across different files where the option is essentially equivalent.


- Leif


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1412/#review4264
-----------------------------------------------------------


On Sept. 6, 2011, 9:35 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1412/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2011, 9:35 a.m.)
> 
> 
> Review request for Asterisk Developers and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> When the manager originates calls, there's no way to add channel variables. THis patch adds a setvar= option in manager.conf for a specific account, much like in sip.conf
> 
> This is different form variables in the originate in that these are set on every call, regardless of settings in the manager client software. Good for usage in combination with the manager event filters.
> 
> 
> This addresses bug 18143.
>     https://issues.asterisk.org/jira/browse/18143
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/config.h 334444 
>   /trunk/main/config.c 334444 
>   /trunk/main/manager.c 334444 
> 
> Diff: https://reviewboard.asterisk.org/r/1412/diff
> 
> 
> Testing
> -------
> 
> In-house testing while developing. Channel variables added (proved by dumpchan() )
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110907/8c471894/attachment.htm>