[asterisk-dev] [Code Review]: AMI :: Debug manager actions in the CLI

[Olle E Johansson]

> On Sept. 7, 2011, 9:42 a.m., Leif Madsen wrote:
> > I don't really like the idea of adding a debug command to the manager.conf file at all. That seems like the wrong way to go about this. I'd much prefer to see you use the logger.conf file to control the logging. This allows the administrator to determine where and what is being logged, and when. You could add a logger channel called 'manager' if that isn't already there. That way an administrator could like to a file, or enable it via the console if they wished. In addition to that, I'd like to see it controlled via a CLI command like 'manager set debug {on|off|<level>}' to give an administrator the ability to control when they see the manager debug on the console.

Ok. Closing this review for the moment until someone has time and resources to fix those issues.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1421/#review4262
-----------------------------------------------------------


On Sept. 7, 2011, 9:14 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1421/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2011, 9:14 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Adds a new option to manager.conf. When enabled, all manager actions will be output in the CLI session, in order to be able to debug a system controlled by AMI connections.
> 
> Red dots will be removed before commit
> 
> 
> This addresses bug ASTERISK-18447.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18447
> 
> 
> Diffs
> -----
> 
>   /team/oej/rana-manager-debug-trunk/configs/manager.conf.sample 334684 
>   /team/oej/rana-manager-debug-trunk/main/manager.c 334684 
> 
> Diff: https://reviewboard.asterisk.org/r/1421/diff
> 
> 
> Testing
> -------
> 
> Works fine on my system and a system at customer site in 1.4 version. The 1.8 version is not much different.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110907/d493910d/attachment.htm>