[asterisk-dev] [Code Review]: No review yet - Set channel variables with setvar= when manager user originates calls

[mjordan]

> On Sept. 7, 2011, 9:20 a.m., mjordan wrote:
> > /trunk/main/manager.c, line 6735
> > <https://reviewboard.asterisk.org/r/1412/diff/1/?file=19959#file19959line6735>
> >
> >     What is the actual format of your setvar?  It looks as if manager.conf would have something like:
> >     
> >     setvar => var1=value
> >     setvar => var2=value
> >     
> >     While there's nothing inherently wrong with this (save that the config can have multiple variables with the same name, which may affect config.c in ways I'm not familiar with), it seems a bit different then how this is usually handled in configs, at least that I'm familiar with.  I would have expected this to be delineated with some token, e.g.,
> >     
> >     setvar => var1=value,var2=value,var3=value
> >     
> >     Note that if the first approach is taken, a sample manager.conf is definitely needed.

I reread this and this does match sip.conf's approach, so disregard.


- mjordan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1412/#review4255
-----------------------------------------------------------


On Sept. 6, 2011, 9:35 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1412/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2011, 9:35 a.m.)
> 
> 
> Review request for Asterisk Developers and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> When the manager originates calls, there's no way to add channel variables. THis patch adds a setvar= option in manager.conf for a specific account, much like in sip.conf
> 
> This is different form variables in the originate in that these are set on every call, regardless of settings in the manager client software. Good for usage in combination with the manager event filters.
> 
> 
> This addresses bug 18143.
>     https://issues.asterisk.org/jira/browse/18143
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/config.h 334444 
>   /trunk/main/config.c 334444 
>   /trunk/main/manager.c 334444 
> 
> Diff: https://reviewboard.asterisk.org/r/1412/diff
> 
> 
> Testing
> -------
> 
> In-house testing while developing. Channel variables added (proved by dumpchan() )
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110907/7a6f171f/attachment.htm>