[asterisk-dev] [Code Review] Add the Cancel Reason Header if a pickup occurs

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1420/#review4254
-----------------------------------------------------------

Ship it!


Thanks, great catch.

- Olle E


On Sept. 7, 2011, 8:12 a.m., schmidts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1420/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2011, 8:12 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Adding the Feature to sent a Reason Header in a SIP Cancel message by set the flag AST_FLAG_ANSWERED_ELSEWHERE before doing a masquerade in the pickup function.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/main/features.c 334680 
> 
> Diff: https://reviewboard.asterisk.org/r/1420/diff
> 
> 
> Testing
> -------
> 
> tested with a Cisco SPA525g2 and sip debug.
> Confirmed by Black187
> 
>     -- Executing [123 at testpickup:2] Dial("SIP/test", "SIP/xxx at yyy,120") in new stack
> ...
>     -- Executing [999 at testpickup:1] NoOp("SIP/test", "starting pickup") in new stack
>     -- Executing [999 at testpickup:2] PickupChan("SIP/test", "SIP/yyy") in new stack
> trying to set FLAG on SIP/yyy
> Scheduling destruction of SIP dialog '631f2bcd31cb6a8b039a4f9c73f110ef at test:5060' in 32000 ms (Method: INVITE)
> Reliably Transmitting (NAT) to yyy:5060:
> CANCEL sip:xxx at yyy SIP/2.0
> Via: SIP/2.0/UDP test:5060;branch=z9hG4bK7838248f;rport
> Max-Forwards: 70
> From: "" <sip:test at test>;tag=as19dc5c35
> To: <sip:xxx at yyy0>
> Call-ID: 631f2bcd31cb6a8b039a4f9c73f110ef at test:5060
> CSeq: 102 CANCEL
> User-Agent: silver.sip
> Reason: SIP;cause=200;text="Call completed elsewhere"
> Content-Length: 0
> 
> 
> Thanks,
> 
> schmidts
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110907/68e206bf/attachment.htm>