[asterisk-dev] [Code Review] Enable manager by default for the testsuite

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1405/#review4242
-----------------------------------------------------------

Ship it!


Looks good.  This could conceivably cause an issue if someone defined manager.general.conf.inc, set the bindaddr to something other than 127.0.0.x, and expected it to work - but I don't see that as a major concern.

- mjordan


On Sept. 1, 2011, 2:07 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1405/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2011, 2:07 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch does two things:
> 
> 1 - Enable the manager by default.  We rely on it for a lot testing, we might as well enable my default.
> 2 - Remove the need for adding manager.general.conf.inc.
> 
> For the manager, we now create the configuration file for more then 1 instance of asterisk automatically.  This is needed because of the bindaddr setting, we need to bind to another virtual loopback adapter.  This was a pain for a test writer to remember, and a pain for somebody maintaining the testsuite.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/configs/manager.conf 2057 
>   asterisk/trunk/lib/python/asterisk/TestCase.py 2057 
>   asterisk/trunk/lib/python/asterisk/asterisk.py 2057 
>   asterisk/trunk/tests/apps/directory_attendant_exit/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/apps/directory_attendant_exit/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/apps/directory_context_operator_exit/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/apps/directory_context_operator_exit/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/apps/directory_operator_exit/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/apps/directory_operator_exit/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/callparking/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/callparking/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/channels/SIP/noload_res_srtp_attempt_srtp/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/directed_pickup/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fastagi/channel-status/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fastagi/connect/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fastagi/control-stream-file/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fastagi/database/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fastagi/stream-file/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_g711_t38/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_g711_t38/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_mix1/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_mix1/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_mix2/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_mix2/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_mix3/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_mix3/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_mix4/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_mix4/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_native_t38/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_native_t38/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_native_t38_ced/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_native_t38_ced/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_no_t38/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_no_t38/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_t38_g711/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_t38_g711/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_timeout1/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_timeout1/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_timeout2/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_timeout2/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_timeout3/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_timeout3/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_timeout4/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_timeout4/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_timeout5/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/fax/gateway_timeout5/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/func_srv/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/manager/login/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/pbx/merge_contexts/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/pbx/merge_contexts/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/pbx/pbx_lua_background/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/pbx/pbx_lua_background/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/pbx/pbx_lua_goto/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/pbx/pbx_lua_goto/configs/ast2/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/regressions/M18882/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/udptl/configs/ast1/manager.general.conf.inc 2057 
>   asterisk/trunk/tests/udptl/configs/ast2/manager.general.conf.inc 2057 
> 
> Diff: https://reviewboard.asterisk.org/r/1405/diff
> 
> 
> Testing
> -------
> 
> Local development box.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110906/c595fa22/attachment-0001.htm>