[asterisk-dev] [Code Review]: Asterisk 1.8 Deadlock in app_queue

[irroot]

> On Aug. 31, 2011, 9:27 a.m., irroot wrote:
> > /branches/1.8/apps/app_queue.c, lines 4589-4593
> > <https://reviewboard.asterisk.org/r/1402/diff/1/?file=19860#file19860line4589>
> >
> >     asking putnopvut if this lock is wrong.
> >     
> >     That sounds wrong, but I seem to recall that if weights are involved then the container would be locked for some reason. I'm not 100% sure though.	
> >     
> >     Ill look into this closer

The lock was added here after ring_one in commit 5225 by markster it was changed to need_weight recently as a local copy of use_weight to avoid deadlock on reload when a incoming call arrived while reloading.

i dont see any need for holding the queues container while dialing out ... 


- irroot


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1402/#review4201
-----------------------------------------------------------


On Aug. 30, 2011, 10:40 a.m., irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1402/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2011, 10:40 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Locking order with queues container.
> 
> 1)the queues container is locked when calling channels this causes a deadlock and is unneeded.
> 2)lock the queues container when running queue_update to maintain correct locking order.
> 
> 
> This addresses bug ASTERISK-18101.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18101
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_queue.c 333923 
> 
> Diff: https://reviewboard.asterisk.org/r/1402/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110905/0a3a60d7/attachment-0001.htm>