[asterisk-dev] [Code Review] chan_misdn has a most broken round robin routiune

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1410/
-----------------------------------------------------------

(Updated Sept. 4, 2011, 7:58 a.m.)


Review request for Asterisk Developers.


Changes
-------

Set the JIRA bug id


Summary
-------

It seems that only one channel per port is allowed to be used in round robin. this is wrong
it should go from port to port and all channels in the port.

on single port devices round robin would never work it now does.

it needs to remember what port / channel to use next.

i have redone the whole section


This addresses bug ASTERISK-18413.
    https://issues.asterisk.org/jira/browse/ASTERISK-18413


Diffs
-----

  /branches/1.8/channels/chan_misdn.c 334220 

Diff: https://reviewboard.asterisk.org/r/1410/diff


Testing
-------

I have now tested this more extensivly with single HFC dongle and digium 4 port card.

the last port / channel is retained and the routine rotates both channels and ports as expected.

previously only one channel per port was taken into account for routing calls.


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110904/7bccb741/attachment.htm>