[asterisk-dev] [Code Review] Allow codecs to be negated in allow and disallow lines.

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1411/#review4215
-----------------------------------------------------------

Ship it!


I think this is an excellent idea! The code looks simple and bullet-proof to me. This would be an excellent candidate for writing a unit test to demonstrate no issues are introduced. I give this a hearty "Ship It" though it might benefit from community discussion just in case I'm crazy. :)

- Terry


On Sept. 3, 2011, 5:25 p.m., Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1411/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2011, 5:25 p.m.)
> 
> 
> Review request for Asterisk Developers and Terry Wilson.
> 
> 
> Summary
> -------
> 
> As discussed on the SQLite3 realtime driver, add the '!' to negate terms when specifying allowed and disallowed codecs.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 334235 
>   /trunk/main/frame.c 334235 
> 
> Diff: https://reviewboard.asterisk.org/r/1411/diff
> 
> 
> Testing
> -------
> 
> Tried multiple codec specifications, both with 'all' as well as '!all', and it works as designed.
> 
> 
> Thanks,
> 
> Tilghman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110904/3b68a9b7/attachment.htm>