[asterisk-dev] [Code Review] res_musiconhold misuse of refs Take 2

[kobaz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1404/#review4204
-----------------------------------------------------------


Thanks!  I wasn't sure if I had fixed it right.  Looks like a good set of changes.  I'll run through some testing.

- kobaz


On Aug. 31, 2011, 9:10 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1404/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2011, 9:10 p.m.)
> 
> 
> Review request for Asterisk Developers and kobaz.
> 
> 
> Summary
> -------
> 
> When starting MusicOnHold from Dial() there are some unref problems which 
> lead to corruptions and crashing.  See ASTERISK-18346 for more.  
> 
> * Fixed moh_alloc() and moh_release() functions not handling the 
> state->class reference consistently.  
> 
> 
> This addresses bug ASTERISK-18346.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18346
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/res/res_musiconhold.c 334212 
> 
> Diff: https://reviewboard.asterisk.org/r/1404/diff
> 
> 
> Testing
> -------
> 
> Replicated the problem.  With the patch, the problem no longer happens.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110902/d637c626/attachment.htm>