[asterisk-dev] [Code Review] Get CDR Congestion Logging Test (and improving whole concept behind CDRTestCase) working.

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1552/#review4890
-----------------------------------------------------------

Ship it!


Looks good

- mjordan


On Nov. 30, 2011, 10:52 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1552/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2011, 10:52 a.m.)
> 
> 
> Review request for Asterisk Developers, Paul Belanger and mjordan.
> 
> 
> Summary
> -------
> 
> A while back, Pabelanger and I were working on creating a general method of testing CDR logging.  At the time, we sort of hit a wall with the order individual call logs were being stuffed into the master cdr file.
> 
> In order to alleviate that, this patch changes the CDRTestCase class to use CDR files generated based on account codes.  At the moment, I'm just specifically using a testsuite account code and loading that cdr file, but it isn't a stretch to say we could put in multiple account codes and use a bunch of different cdr logs so that the order of which channel hangs up isn't important.
> 
> In addition to that, a couple minor changes were made to the cdr_originate_sip_congestion_log test.  It now runs without any chance for timing based failures (before it was 50/50 whether congestion or failure would come first/second, now only one action is checked and logged, that being the congestion).
> 
> If this seems appropriate, I'll move forward with making the CDR Expectations use a variable to determine which file they should be checking against.
> 
> 
> Diffs
> -----
> 
>   /asterisk/team/group/cdr_test_log_congestion/lib/python/asterisk/CDRTestCase.py 2769 
> 
> Diff: https://reviewboard.asterisk.org/r/1552/diff
> 
> 
> Testing
> -------
> 
> Checked to see how the test was logging CDR in separate files, made sure test was passing appropriately.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111130/21888efe/attachment.htm>