[asterisk-dev] [Code Review] rtp / rtcp set debug ip doesnt work correctly in 1.8

[schmidts]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1600/
-----------------------------------------------------------

(Updated Nov. 28, 2011, 8 a.m.)


Review request for Asterisk Developers and wdoekes.


Changes
-------

thanks wdoekes for your comments. changed the things you have noticed.


Summary
-------

In 1.8 rtp and rtcp set debug ip also needs a port to work. if you only use for example rtp set debug ip 10.10.10.10 then it would look for 10.10.10.10 port 0 and will not show any rtp packets regarding this ip coming to another port.

regarding to the Usage output of rtp set debug ip the port is optional and not necessary.

by adding a check if a port is present we can use the right compare function. ast_sockaddr_cmp or ast_sockaddr_cmp_addr


This addresses bug ASTERISK-18693.
    https://issues.asterisk.org/jira/browse/ASTERISK-18693


Diffs (updated)
-----

  branches/1.8/res/res_rtp_asterisk.c 346291 

Diff: https://reviewboard.asterisk.org/r/1600/diff


Testing
-------

tested with rtp set debug ip with and without port and it works like expected.

rtcp set debug ip also works.


Thanks,

schmidts

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111128/2fd2dbe6/attachment.htm>