[asterisk-dev] [Code Review] Fix more res_jabber resource leaks

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1553/
-----------------------------------------------------------

(Updated Nov. 23, 2011, 10:25 a.m.)


Review request for Asterisk Developers and jrose.


Changes
-------

Simplifications with regard to mjordan's comments.


Summary
-------

There are many resource leaks inside res_jabber caused by uses of ASTOBJ_CONTAINER_FIND without a corresponding UNREF.  This fixes all the instances I saw and additionally fixes aji_client and aji_buddy leaks into chan_gtalk and chan_jingle.


Diffs (updated)
-----

  trunk/channels/chan_gtalk.c 345734 
  trunk/channels/chan_jingle.c 345734 
  trunk/include/asterisk/jabber.h 345734 
  trunk/res/res_jabber.c 345734 

Diff: https://reviewboard.asterisk.org/r/1553/diff


Testing
-------

Tested res_jabber via distributed devstate changes in conjunction with openfire XMPP server.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111123/b5fcde79/attachment.htm>