[asterisk-dev] [Code Review]: Change the default nat setting to "yes"

[Terry Wilson]

> On Nov. 21, 2011, 8:19 a.m., mjordan wrote:
> > /branches/1.4/channels/chan_sip.c, line 19114
> > <https://reviewboard.asterisk.org/r/1591/diff/1/?file=21808#file21808line19114>
> >
> >     Red blob.
> >     
> >     I'm not a big fan of linking to an ASTERISK issue in the source code, simply because now I have to go pull up Jira in order to figure out why we default it to yes.  I'd rather have a sentence or two here stating why.

Ok. For the most part I don't think it actually matters as far as the code is concerned why we default to yes, I just added a note pointing to the issue number since it was a change in behavior in a released branch. But really the best place to document this would be in the commit message since that is most likely where someone would look for information regarding *why* the change was made, so I'll just remove that part of the comment altogether.


- Terry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1591/#review4828
-----------------------------------------------------------


On Nov. 18, 2011, 10:50 a.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1591/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2011, 10:50 a.m.)
> 
> 
> Review request for Asterisk Developers and Kevin Fleming.
> 
> 
> Summary
> -------
> 
> Change the default to nat=yes, update CHANGES explaining the change, remove nat= from example peers, and add a big warning about having different nat= settings in [general] and peer configs.
> 
> 
> This addresses bug ASTERISK-18862.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18862
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/configs/sip.conf.sample 345544 
>   /branches/1.4/channels/chan_sip.c 345544 
>   /branches/1.4/CHANGES 345544 
> 
> Diff: https://reviewboard.asterisk.org/r/1591/diff
> 
> 
> Testing
> -------
> 
> Created users of various nat flavors and verified that the default was changed and that 'sip show peer' reported that nat was set as it should be.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111121/1b9b4968/attachment-0001.htm>