[asterisk-dev] [Code Review] Restore SIP DTMF overlap dialing method.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1582/
-----------------------------------------------------------

(Updated Nov. 14, 2011, 1:23 p.m.)


Review request for Asterisk Developers, mjordan and Pavel Troller.


Changes
-------

Found and added original reviewboard review link.


Summary (updated)
-------

See ASTERISK-18702 it has a very good description of the issue.

Basically, the recent fix for ASTERISK-17288 to get RFC3578 SIP overlap support working correctly removed a long standing ability to do overlap dialing using DTMF in the early media phase of a call.

The large change block for PAGE2 flags is just to make room for the now two bit field SIP_PAGE2_ALLOWOVERLAP.

I started with Pavel Troller's chan_sip.diff patch on issue ASTERISK-18702.
Original review: https://reviewboard.asterisk.org/r/1517/

Also:

* Renames SIP_GET_DEST_PICKUP_EXTEN_FOUND to SIP_GET_DEST_EXTEN_MATCHMORE since that is what it really means.

* Fixed get_destination() inconsistency with the pickup extension matching.

* Fixed initialization of PAGE3 of global_flags in reload_config().


This addresses bugs ASTERISK-17288 and ASTERISK-18702.
    https://issues.asterisk.org/jira/browse/ASTERISK-17288
    https://issues.asterisk.org/jira/browse/ASTERISK-18702


Diffs
-----

  /branches/1.8/channels/sip/include/sip.h 345158 
  /branches/1.8/configs/sip.conf.sample 345158 
  /branches/1.8/UPGRADE.txt 345158 
  /branches/1.8/channels/chan_sip.c 345158 

Diff: https://reviewboard.asterisk.org/r/1582/diff


Testing
-------

It compiles. :)


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111114/347ffbcf/attachment.htm>