[asterisk-dev] [Code Review]: Restore SIP DTMF overlap dialing method.

[rmudgett]

> On Nov. 14, 2011, 10:54 a.m., mjordan wrote:
> > /branches/1.8/channels/chan_sip.c, line 15185
> > <https://reviewboard.asterisk.org/r/1582/diff/2/?file=21719#file21719line15185>
> >
> >     Yup, it shouldn't blindly match *8 to *81, so this shouldn't be strncmp.  I had compared this to the check done on line 15208 - which is strncmp.  I doubt the inconsistency is intentional.
> >

The two comparisons are for different purposes.  The first comparison on 15181 is looking for an exact match.  The second one on 15208 is looking for a possible match if only more digits were available.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1582/#review4805
-----------------------------------------------------------


On Nov. 14, 2011, 11:02 a.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1582/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2011, 11:02 a.m.)
> 
> 
> Review request for Asterisk Developers, mjordan and Pavel Troller.
> 
> 
> Summary
> -------
> 
> See ASTERISK-18702 it has a very good description of the issue.
> 
> Basically, the recent fix for ASTERISK-17288 to get RFC3578 SIP overlap support working correctly removed a long standing ability to do overlap dialing using DTMF in the early media phase of a call.
> 
> The large change block for PAGE2 flags is just to make room for the now two bit field SIP_PAGE2_ALLOWOVERLAP.
> 
> I started with Pavel Troller's chan_sip.diff patch on issue ASTERISK-18702.
> 
> Also:
> 
> * Renames SIP_GET_DEST_PICKUP_EXTEN_FOUND to SIP_GET_DEST_EXTEN_MATCHMORE since that is what it really means.
> 
> * Fixed get_destination() inconsistency with the pickup extension matching.
> 
> * Fixed initialization of PAGE3 of global_flags in reload_config().
> 
> 
> This addresses bugs ASTERISK-17288 and ASTERISK-18702.
>     https://issues.asterisk.org/jira/browse/ASTERISK-17288
>     https://issues.asterisk.org/jira/browse/ASTERISK-18702
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/sip/include/sip.h 344897 
>   /branches/1.8/configs/sip.conf.sample 344897 
>   /branches/1.8/channels/chan_sip.c 344897 
>   /branches/1.8/CHANGES 344897 
> 
> Diff: https://reviewboard.asterisk.org/r/1582/diff
> 
> 
> Testing
> -------
> 
> It compiles. :)
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111114/db855f7b/attachment-0001.htm>