[asterisk-dev] [Code Review]: Remove need for registration strings in sip.conf

[wdoekes]

> On July 9, 2010, 4:49 a.m., Olle E Johansson wrote:
> > This should NOT at all be in the PEER.... See my e-mail.

I tried to find the relevant e-mail, but I did only find your thunder and rain post.

Gut feeling tells me a register=yes option in the peer definition is way easier for users to grasp than a separate register statement like we have now.

The final verdict on this was to scrap it, or?


- wdoekes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/718/#review2357
-----------------------------------------------------------


On June 29, 2010, 5:57 a.m., Nick Lewis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/718/
> -----------------------------------------------------------
> 
> (Updated June 29, 2010, 5:57 a.m.)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> This change adds the ability to specify the sip registration expiry and registrar host to the peer configuration items. This permits all registration details that are available to the registration string to be also available to the peer definitions. The users of sip.conf can enable registration by setting register=yes in the peer and do not need to concern themselves with the strange format of the registration strings
> 
> Suggest inclusion in 1.8
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 268968 
>   trunk/channels/sip/config_parser.c 268968 
>   trunk/channels/sip/include/sip.h 268968 
>   trunk/configs/sip.conf.sample 268968 
>   trunk/doc/tex/realtime.tex 268968 
> 
> Diff: https://reviewboard.asterisk.org/r/718/diff
> 
> 
> Testing
> -------
> 
> Compile, run and confirm in cli sip show registry
> 
> 
> Thanks,
> 
> Nick
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111111/82ff6f81/attachment.htm>