[asterisk-dev] [Code Review] app_voicemail [general] variables zonetag and locale are not set on mailbox until after reload

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1570/
-----------------------------------------------------------

(Updated Nov. 8, 2011, 8:47 a.m.)


Review request for Asterisk Developers and shawkris.


Changes
-------

> For tracking purposes, go ahead and file an ASTERISK issue to tie this to.

Added bug report.

> I'd keep these comments.

Yea.. I added them for a reason. I shall reconsider documenting why loading the actual users is done last. (Actually.. this should be done automatically if we're parsing the voicemail conf the pabelanger way (iterating over the settings instead of looking them up as needed).)

> Have you checked that the unit tests that parse user options still pass?

I would have to look at the testing stuff. Haven't fiddled with that yet.


Summary
-------

shawkris identified the problem that a couple of voicemail variables from [general] are not set on the mailboxes until after a reload.

I confirmed that: the variables in question are those that are set by populate_defaults(); some of them have not been loaded yet when the mailboxes are created the first time.

Specifically: the VM_PBXSKIP flag in globalflags, zonetag, locale

I moved the create-mailbox stuff to after all the settings are loaded so this shouldn't be an issue anymore.


This addresses bug ASTERISK-18838.
    https://issues.asterisk.org/jira/browse/ASTERISK-18838


Diffs
-----

  /branches/1.8/apps/app_voicemail.c 343785 

Diff: https://reviewboard.asterisk.org/r/1570/diff


Testing
-------

It compiles.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111108/5f0948ce/attachment-0001.htm>