[asterisk-dev] [Code Review] ast_indicate(chan, -1) don't stop playing tones

[schmidts]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1559/#review4676
-----------------------------------------------------------



branches/1.8/main/channel.c
<https://reviewboard.asterisk.org/r/1559/#comment8868>

    i am not sure if its a good idea to only look at the _condition and stop playtones.
    AFAIK chan->tech->indicate looks mostly on the visible_indication which is here set to 0 if _condition is < 0.
    
    this could means chan->tech->indicate is doing everything fine with indication 0 but you maybe do stop_playtones twice and i dont know if this could lead to other problems.
    
    if this is a reproduceable problem you should try to see what happens in the used chan->tech->indicate function. maybe you can see some difference there between condition and visible_indication.
    
    


best regards

- schmidts


On Nov. 2, 2011, 2:47 a.m., may213 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1559/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2011, 2:47 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> ast_indicate_data function must call ast_stop_playtones when condition arg is negative, but don't call ast_stop_playtones if indicate function of channel driver return zero result.
> 
> If channel->tech->indicate return zero then processing go to indicate_cleanup before processing negative condition arg, it's bug
> because we must stop tone generator if condition arg is negative independent of returned from tech->indicate value.
> 
> The patch call ast_stop_playtones before processing indicate return value.
> 
> 
> This addresses bug 18803.
>     https://issues.asterisk.org/jira/browse/18803
> 
> 
> Diffs
> -----
> 
>   branches/1.8/main/channel.c 338895 
> 
> Diff: https://reviewboard.asterisk.org/r/1559/diff
> 
> 
> Testing
> -------
> 
> app_queue work correctly with 'r' option on dahdi channel with patch.
> 
> 
> Thanks,
> 
> may213
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111103/8d712c34/attachment.htm>