[asterisk-dev] [Code Review]: Add mute all participants; play participant count to ConfBridge

[mjordan]

> On Nov. 3, 2011, 12:01 p.m., David Vossel wrote:
> > /trunk/apps/app_confbridge.c, lines 1567-1571
> > <https://reviewboard.asterisk.org/r/1518/diff/2/?file=21583#file21583line1567>
> >
> >     Umm, if we don't mute the admin, the admin will still hear the sound file that they are muted, but they won't actually be muted.  Then when the admin starts making fun of people in the conference everyone will hear them even though the admin was told the line is muted.  This may or may not be the expected behavior.
> >     
> >     It might be better to go ahead and make this function mute everyone and make the admins explicitly unmute themselves after mute all is used. If we don't do it this way, we should make sure to comment in the documentation that the admin will not be affected by this action.

Ha!  That's pretty funny.  Even better, we sort of 'lie' to the admin, since we playback 'the conference is now muted' - when they actually aren't.  Hilarity ensues.

This may still be the intended behavior though.  If you are a presenter on a conference (admin), and you want to mute the entire conference room so that you can speak without anyone interrupting you, then this feature makes sense.  That might be what was intended - but if so, then yes, it should be clearly documented.  Before going any further with this patch, I'll ping it back to the author for more info.


- mjordan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1518/#review4664
-----------------------------------------------------------


On Nov. 3, 2011, 11:05 a.m., mjordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1518/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2011, 11:05 a.m.)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> This patch adds two new menu features to ConfBridge, admin_toggle_menu_participants and participant_count.  The admin action will globally mute / unmute all participants on a conference, while the participant count simply exposes the existing participant count function to the conference bridge menu.
> 
> Note that this is a port of the patch supplied by Kevin Reeves on ASTERISK-18204.  Very minor modifications were made to that patch, including adding sound file overriding to the config parser and some general overall cleanup.
> 
> This also makes a minor change that outputs the caller ID of the participants when the CLI command to list a specific conf bridge is used.  As this is useful and a minor modification, it was left in with this patch.
> 
> 
> This addresses bug ASTERISK-18204.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18204
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 343280 
>   /trunk/apps/app_confbridge.c 343280 
>   /trunk/apps/confbridge/conf_config_parser.c 343280 
>   /trunk/apps/confbridge/include/confbridge.h 343280 
> 
> Diff: https://reviewboard.asterisk.org/r/1518/diff
> 
> 
> Testing
> -------
> 
> Tested using a polycom phone and zoiper softphone.  No sound file quality issues were detecting in playing back the global sound using the conference bridge channel, which was an issue Kevin originally reported with his first implementation.  There did not appear to be any locking issues with the implementation proposed by Kevin.
> 
> 
> Thanks,
> 
> mjordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111103/11d46a6c/attachment-0001.htm>