[asterisk-dev] [Code Review] BLF Subscriptions Causes SIP Deadlock

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1563/#review4657
-----------------------------------------------------------



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1563/#comment8857>

    Since the locking here is complex, lets make a note of what is locked and what is not when this gets called



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1563/#comment8855>

    Already discussed offline, but the sip_pvt still needs to be protected.


- mjordan


On Nov. 3, 2011, 10:15 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1563/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2011, 10:15 a.m.)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> Fix a locking inversion that causes deadlocks during BLF subscriptions.  This moves locking back outside of sip_send_mwi_to_peer and adds locking where it was needed.
> 
> 
> This addresses bug ASTERISK-18663.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18663
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 342600 
> 
> Diff: https://reviewboard.asterisk.org/r/1563/diff
> 
> 
> Testing
> -------
> 
> Compile
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111103/fdb3eb90/attachment.htm>