[asterisk-dev] [Code Review] ast_indicate(chan, -1) don't stop playing tones

[may213]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1559/
-----------------------------------------------------------

(Updated Nov. 1, 2011, 5:35 p.m.)


Review request for Asterisk Developers.


Summary
-------

ast_indicate_data function must call ast_stop_playtones with negative condition argument, but don't call ast_stop_playtones if indicate function of channel driver return zero result.

If channel->tech->indicate return zero then processing go to indicate_cleanup before processing negative condition, it's bug
because we must stop tone generator if condition arg is negative independ of return from tech->indicate value.

The patch call ast_stop_playtones before processing indicate return value.


This addresses bug 18803.
    https://issues.asterisk.org/jira/browse/18803


Diffs (updated)
-----

  branches/1.8/main/channel.c 338895 

Diff: https://reviewboard.asterisk.org/r/1559/diff


Testing
-------

app_queue work correctly with 'r' option on dahdi channel with patch.


Thanks,

may213

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111101/f22e1048/attachment.htm>