[asterisk-dev] [Code Review] Stop trying to uri_encode the display name for the caller ID

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1235/
-----------------------------------------------------------

(Updated 2011-05-31 11:22:36.724585)


Review request for Asterisk Developers, Russell Bryant and David Vossel.


Changes
-------

Adds a specialized function similar to ast_encode_uri for display name that just escapes the quotation marks and doesn't do any other stuff like what's found in encode_uri.

Fixes a few stylistic concerns.

Tested escape_quotes by changing n to a variety of strings before invocation.  Made sure it wouldn't segfault by overflowing the input buffer, but like before as when using ast_encode_uri if it cuts off early, it'll still leave the display name without an end quote and this will cause the uri to parse incorrectly and the call will fail.


Summary
-------

Under SIP pedantic mode, this function was encoding strings meant for the display name into into a URI safe format when this was not specified in the SIP RFCs.  I also took the liberty of adding a little commentary.

pedantic mode was the default in Asterisk 1.8+


This addresses bug 18298.
    https://issues.asterisk.org/view.php?id=18298


Diffs (updated)
-----

  /branches/1.8/channels/chan_sip.c 321510 

Diff: https://reviewboard.asterisk.org/r/1235/diff


Testing
-------

A number of different calls with user names including more interesting UTF-8 characters from a variety of characters from a variety of sources including trema (like German umlaut characters), Kanji (Japanese pictographic characters), Sanskrit (phonetic characters for one of India's languages), and Cyrillic (Russian).  Whether or not they'll display properly depends on the receiving phone... My Grandstream phone doesn't like the higher end UTF-8 characters, but all of my soft phones read them fine.

Testing involved a manually set DAHDI channel to have odd caller ID and an incoming call from another Asterisk Box sending SIP from a phone set to also have a display name with high UTF-8 chars.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110531/297f5f5f/attachment-0001.htm>