[asterisk-dev] [Code Review] Add RTP keep-alives back to Asterisk 1.8 after they were accidentally removed when moving to the RTP Engine API.

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1226/#review3646
-----------------------------------------------------------

Ship it!


Looks good, unless someone can think of a reason why breaking the RTP engine ABI would be really bad and that we should find a creative way to avoid that.


/branches/1.8/include/asterisk/rtp_engine.h
<https://reviewboard.asterisk.org/r/1226/#comment7328>

    This breaks the ABI.  I can't think of any reason that would matter for this particular API though.  Can you?


- Russell


On 2011-05-23 15:23:06, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1226/
> -----------------------------------------------------------
> 
> (Updated 2011-05-23 15:23:06)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The move to RTP engine left out RTP keep-alives. This is a port of RTP keep-alives from 1.6.2 to the RTP Engine API.
> 
> 
> This addresses bug 18697.
>     https://issues.asterisk.org/view.php?id=18697
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 320161 
>   /branches/1.8/include/asterisk/rtp_engine.h 320161 
>   /branches/1.8/main/rtp_engine.c 320161 
>   /branches/1.8/res/res_rtp_asterisk.c 320161 
> 
> Diff: https://reviewboard.asterisk.org/r/1226/diff
> 
> 
> Testing
> -------
> 
> sip.conf
> [global]
> rtpkeepalive=1 ; second
> 
> extensions.conf
> [default]
> exten => test2,1,Answer
> exten => test2,n,Playback(vm-goodbye)
> exten => test2,n,Wait(10)
> 
> *CLI> rtp set debug on
> 
> sipp -sn uac 127.0.0.1 -s test2 -d 10000 -m 1 -rtp_echo
> 
> Verified the CLI shows once per second: Sent Comfort Noise RTP packet to 127.0.1.1:6000 (type 02, seq 062924, ts 008160, len 000001)
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110527/cfd6c136/attachment.htm>