[asterisk-dev] [Code Review] chan_local locking cleanup

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1231/#review3641
-----------------------------------------------------------

Ship it!


This patch rocks.  Once you're happy with the testing that has been done, this looks good to go to me.  Nice work!


/trunk/channels/chan_local.c
<https://reviewboard.asterisk.org/r/1231/#comment7309>

    \pre and \post can be used to document preconditions and postconditions in doxygen as an alternative to just \note.



/trunk/channels/chan_local.c
<https://reviewboard.asterisk.org/r/1231/#comment7310>

    Yeah, I think we should make it standard that the ast_channel is locked before _all_ ast_channel_tech callbacks.  Anywhere it is not done is an oversight.  That's going to take some code review of all of the callback implementations to make sure they handle it properly though ...


- Russell


On 2011-05-25 15:01:19, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1231/
> -----------------------------------------------------------
> 
> (Updated 2011-05-25 15:01:19)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Introduces the awesome_locking() function and cleans up all the unnecessary deadlock avoidance junk we do.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_local.c 320715 
> 
> Diff: https://reviewboard.asterisk.org/r/1231/diff
> 
> 
> Testing
> -------
> 
> I made a call. Obviously more testing is required under load.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110527/9e337c04/attachment.htm>