[asterisk-dev] [Code Review] app_directed_pickup Implement the ability to remove a channel group on bridged channel

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1118/#review3626
-----------------------------------------------------------



/trunk/apps/app_directed_pickup.c
<https://reviewboard.asterisk.org/r/1118/#comment7292>

    The DOWN state was added by issue 14005.  It did not add the DOWN state to the *8 pickup check though.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/1118/#comment7293>

    The defined locking order is the channels container then the channel.  This is not the correct way to fix the deadlock.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/1118/#comment7296>

    space after comma.  I prefer one declaration per line though:
    int var1;
    int var2;



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/1118/#comment7297>

    spacing around =



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/1118/#comment7298>

    spacing around =



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/1118/#comment7294>

    The NULL should be c0 here because you don't know how long the macro will be running so c0 needs to be put in autoservice.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/1118/#comment7299>

    spacing around =



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/1118/#comment7300>

    spacing around =



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/1118/#comment7295>

    The NULL needs to be c1 here for the same reason as above.


- rmudgett


On 2011-05-26 03:58:55, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1118/
> -----------------------------------------------------------
> 
> (Updated 2011-05-26 03:58:55)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> as a companion to 0018825 to aid with the move from call-limits to channel group variables. the problem with pickup and queue is that they manage channels outside the dialplan and need "helpers" to deal with channel groups.
> 
> in the case of pickup when a call is placed to a extension with say a "<EXTEN>@called" channel group when it is picked up this needs to be cleared to allow further calls when call waiting is disabled.
> 
> exten => s,n,GotoIf($[$[${ GROUP_COUNT(${ARG1}@called)} >= 1] | $[${GROUP_COUNT(${ARG1}@caller)} >= 1] | $[${GROUP_COUNT(${ARG1}@pickup)} >= 1] | $[${GROUP_COUNT(${ARG1}@qagent)} >= 1]]?s-BUSY,1)
> 
> where
> caller is set when a call is placed.
> called is set when a call is received
> pickup is set when before calling pickup in the dialplan
> qagent is set with patch to queue
> 
> Hope this is found to be useful and finds a home in trunk. 
> 
> not sure what time to put in the "wait for bridge" perhaps there is a better method ?? 
> 
> 
> This addresses bug 18830.
>     https://issues.asterisk.org/view.php?id=18830
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_directed_pickup.c 320772 
>   /trunk/main/channel.c 320772 
> 
> Diff: https://reviewboard.asterisk.org/r/1118/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110526/97ed3603/attachment-0001.htm>