[asterisk-dev] [Code Review] chan_local locking cleanup

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1231/#review3620
-----------------------------------------------------------


using my nasty looping channels dialplan, still able to get a deadlock in chan_local, by calling 10030, ignoring the exceptionally long queue to xyz.
This was existed before.
 
=== -------------------------------------------------------------------
===
=== Thread ID: 0xb5043b70 [Thread 5879]: (pbx_thread           started at [ 5211] pbx.c ast_pbx_start())
=== ---> Lock #0 (channel.c): MUTEX 4751 ast_write chan 0x1047fa30 (1)
=== ---> Lock #1 (chan_local.c): MUTEX 592 local_write p 0x10478718 (1)
=== ---> Waiting for Lock #2 (chan_local.c): MUTEX 336 local_bridgedchannel p 0x10486978 (1)
=== --- ---> Locked Here: chan_local.c line 592 (local_write)
=== -------------------------------------------------------------------
===
=== Thread ID: 0xb5007b70 [Thread 5880]: (pbx_thread           started at [ 5211] pbx.c ast_pbx_start())
=== ---> Lock #0 (channel.c): MUTEX 4751 ast_write chan 0x1048c830 (1)
=== ---> Lock #1 (chan_local.c): MUTEX 592 local_write p 0x10486978 (1)
=== ---> Lock #2 (chan_local.c): MUTEX 513 check_bridge p->chan->_bridge 0x104957f8 (2)
=== ---> Lock #3 (chan_local.c): MUTEX 515 check_bridge p->owner 0x10488690 (2)
=== ---> Waiting for Lock #4 (chan_local.c): MUTEX 336 local_bridgedchannel p 0x10478718 (1)
=== --- ---> Locked Here: chan_local.c line 592 (local_write)

- Alec


On 2011-05-25 09:49:42, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1231/
> -----------------------------------------------------------
> 
> (Updated 2011-05-25 09:49:42)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Introduces the awesome_locking() function and cleans up all the unnecessary deadlock avoidance junk we do.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_local.c 320715 
> 
> Diff: https://reviewboard.asterisk.org/r/1231/diff
> 
> 
> Testing
> -------
> 
> I made a call. Obviously more testing is required under load.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110525/bca33477/attachment.htm>