[asterisk-dev] [Code Review] Give zombies a safe channel driver to use.

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1224/#review3618
-----------------------------------------------------------

Ship it!


- Russell


On 2011-05-20 15:06:26, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1224/
> -----------------------------------------------------------
> 
> (Updated 2011-05-20 15:06:26)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and David Vossel.
> 
> 
> Summary
> -------
> 
> Recent crashes from zombie channels suggests that they need a safe home to goto.
> 
> When a masquerade happens, the physical part of the zombie channel is hungup.  The hangup normally sets the channel private pointer to NULL.  If someone then blindly does a callback to the channel driver, a crash is likely because the private pointer is NULL.
> 
> The masquerade now sets the channel technology of zombie channels to the kill channel driver.
> 
> 
> This addresses bugs 19116 and 19310.
>     https://issues.asterisk.org/view.php?id=19116
>     https://issues.asterisk.org/view.php?id=19310
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/include/asterisk/channel.h 320060 
>   /branches/1.8/main/channel.c 320060 
>   /branches/1.8/main/features.c 320060 
> 
> Diff: https://reviewboard.asterisk.org/r/1224/diff
> 
> 
> Testing
> -------
> 
> Tested a version of this patch without the zombie check committed for issue 19116.  The crash was avoided.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110525/612823a4/attachment-0001.htm>