[asterisk-dev] [Code Review] chan_local locking cleanup

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1231/#review3609
-----------------------------------------------------------


using the test dialplan of looping local channel calls from https://issues.asterisk.org/view.php?id=18028

    -- Executing [10020 at phones:1] Set("DAHDI/35-1", "i=10019") in new stack
    -- Executing [10020 at phones:2] Dial("DAHDI/35-1", "Local/10019 at phones") in new stack
[2011-05-25 20:17:06.237237] ERROR[32186]: lock.c:407 __ast_pthread_mutex_unlock: channel.c line 5658 (ast_call): mutex 'chan' freed more times than we've locked!
[2011-05-25 20:17:06.237284] ERROR[32186]: lock.c:438 __ast_pthread_mutex_unlock: channel.c line 5658 (ast_call): Error releasing mutex: Operation not permitted
    -- Couldn't call Local/10019 at phones

not that this is even intended to assist with #18028

 


/trunk/channels/chan_local.c
<https://reviewboard.asterisk.org/r/1231/#comment7279>

    should this be 
    if (!(bridge = ast_bridged_channel(tmp))) {
    
    my compile complained with:
    "chan_local.c: In function 'local_queryoption':
    chan_local.c:391: error: lvalue required as left operand of assignment
    


- Alec


On 2011-05-24 17:48:40, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1231/
> -----------------------------------------------------------
> 
> (Updated 2011-05-24 17:48:40)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Introduces the awesome_locking() function and cleans up all the unnecessary deadlock avoidance junk we do.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_local.c 320715 
> 
> Diff: https://reviewboard.asterisk.org/r/1231/diff
> 
> 
> Testing
> -------
> 
> I made a call. Obviously more testing is required under load.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110525/f33843c8/attachment.htm>