[asterisk-dev] [Code Review] chan_local fixed

[David Vossel]

> On 2011-05-24 17:18:02, kobaz wrote:
> > Does this fix a particular bug?  Or is it a general cleanup?

Sorry, my summary is confusing.  Nothing is broken in chan_local.

This patch addresses is the unmaintainable locking nightmare we've collected over the years in chan_local.  The awesome_locking() function gives all the functions a central location to go to perform grabbing the tech_pvt and channel locks.  This guarantees proper locking order is used and minimizes some very complex logic that was else where.  I did however find a few bugs when I was going through the code though, nothing major though.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1231/#review3605
-----------------------------------------------------------


On 2011-05-24 17:14:20, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1231/
> -----------------------------------------------------------
> 
> (Updated 2011-05-24 17:14:20)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Introduces the awesome_locking() function and cleans up all the unnecessary deadlock avoidance junk we do.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_local.c 320715 
> 
> Diff: https://reviewboard.asterisk.org/r/1231/diff
> 
> 
> Testing
> -------
> 
> I made a call. Obviously more testing is required under load.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110524/2b6b4034/attachment.htm>