[asterisk-dev] [Code Review] On demand AMI event filters

[Olle E Johansson]

> On 2011-05-24 03:15:16, Olle E Johansson wrote:
> > I would rather see 
> > 
> > Action: AmiFilter
> > Operation: Add
> > 
> > That would open for "Operation: Delete" to delete active filters. I am not sure that you need the strange syntax with two colons, since the filter is always for events. Or am I wrong?
> > 
> > /O
> 
> FeyFre wrote:
>     > I am not sure that you need the strange syntax with two colons
>     Event filter works also for non-"Event" header, i.e if I have filter "eventfilter=!UserEvent: bla-bla-bla" in my manager.conf I shall not receive AMI events which has "UserEvent: bla-bla-bla" line among headers. So "double colon"-ed syntax is legal and useful(just retested on r315054).

Ok then :-) Thanks for the explanation.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1228/#review3599
-----------------------------------------------------------


On 2011-05-23 21:19:14, kobaz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1228/
> -----------------------------------------------------------
> 
> (Updated 2011-05-23 21:19:14)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> There is already support for white and black filters for AMI events in manager.conf, but they are defined statically.
> 
> It would be really great to be able to log in and add filters on the fly for just the current session.
> 
> 
> Diffs
> -----
> 
>   trunk/main/manager.c 320708 
> 
> Diff: https://reviewboard.asterisk.org/r/1228/diff
> 
> 
> Testing
> -------
> 
> ----------------------
> Test 1
> ----------------------
> 
> Log into AMI, events: all
> 
> Action: UserEvent
> UserEvent: foo
> MyValue: bar
> 
> (userevent recieved)
> 
> Action: FilterAdd
> Filter: !UserEvent: foo
> 
> Action: UserEvent
> UserEvent: foo
> MyValue: bar
> 
> (no foo userevent event received)
> 
> ----------------------
> Test 2
> ----------------------
> 
> Log into AMI session 1, events: all
> Log into AMI session 2, events: all
> 
> AMI session 1:
>   Action: FilterAdd
>   Filter: Event: PeerStatus
> 
>   (only peerstatus events received)
> 
> AMI session 2:
>   (all events received)
> 
> 
> Thanks,
> 
> kobaz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110524/cbb2f0a7/attachment.htm>