[asterisk-dev] [Code Review] Allow Setting Bitsize and make SRTP optional chan_sip

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1173/
-----------------------------------------------------------

(Updated 2011-05-21 06:41:17.227585)


Review request for Asterisk Developers.


Changes
-------

Ok some changes to ensure i respond with the key in the invite this allows more interop
the 32bit addition to encryption will ensure use of 32bit keylen in INVITE.

still have much testing to do on the "try" option but have better key negotiation working.


Summary
-------

change the encruption option to tristate with optional bit setting
also make this a global option.

qwell sugests a second option for bitlen have no problem with that.


This addresses bug 19335.
    https://issues.asterisk.org/view.php?id=19335


Diffs (updated)
-----

  /team/irroot/t38gateway-trunk/channels/chan_sip.c 319935 
  /team/irroot/t38gateway-trunk/channels/sip/include/sdp_crypto.h 319935 
  /team/irroot/t38gateway-trunk/channels/sip/include/sip.h 319935 
  /team/irroot/t38gateway-trunk/channels/sip/include/srtp.h 319935 
  /team/irroot/t38gateway-trunk/channels/sip/sdp_crypto.c 319935 

Diff: https://reviewboard.asterisk.org/r/1173/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110521/62ceae14/attachment.htm>