[asterisk-dev] [Code Review] app_pickup: implement ${PICKUPRESULT} for dialplan related pickups

[rmudgett]

> On 2011-05-18 09:50:40, rmudgett wrote:
> > I think the Pickup applications should return nonzero to quit the dialplan when they are successful.  The channel has become a zombie and should not continue processing the dialplan.  If the pickup failed then the application should return zero to continue processing the dialplan.  There is no need to have a status channel variable when this happens.
> 
> Alec Davis wrote:
>     agreed, and I see this will now be done in the cleanup to app_directed_pickup in https://reviewboard.asterisk.org/r/1221/
>     
>     The only time ${PICKUPRESULT} may be of any use, is in the hangup 'h' priority, and perhaps if the pickup application ever supports 'continue' in dialplan type options.
>

With the pickup applications return status change, the PICKUPRESULT could be done by dialplan:

exten => whatever,n,Set(PICKUPRESULT=SUCCESS)
same => n,Pickup()
same => n,Set(PICKUPRESULT=FAILED)
...


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1217/#review3565
-----------------------------------------------------------


On 2011-05-14 04:50:35, Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1217/
> -----------------------------------------------------------
> 
> (Updated 2011-05-14 04:50:35)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> app_directed_pickup failed to report back to dialplan success or failure of pickup.
> Which then meant the dialplan writer was unable to determine whether further action was required.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_directed_pickup.c 318867 
> 
> Diff: https://reviewboard.asterisk.org/r/1217/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110518/0a21b19f/attachment.htm>