[asterisk-dev] [Code Review] Crash when using directed pickup applications.

[rmudgett]

> On 2011-05-18 17:33:34, Alec Davis wrote:
> > While your optimizing/cleaning up, what about the various find_by_xxxx, they swap 'chan' and 'c' when referring to the pickup target.
What about a consistant, 'chan' is us, and 't' is the pickup target.
That might help stop some headaches in future.

I'll do that as a separate patch since those name changes would add to the confusion in the patch.  Also, I would prefer 'chan' is us and 'target' is the object being compared for the pickup target.  I dislike single char variable names since they require a special search setup.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1221/#review3574
-----------------------------------------------------------


On 2011-05-18 16:24:16, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1221/
> -----------------------------------------------------------
> 
> (Updated 2011-05-18 16:24:16)
> 
> 
> Review request for Asterisk Developers and Alec Davis.
> 
> 
> Summary
> -------
> 
> The directed pickup applications can cause a crash if the pickup was successful because the dialplan keeps executing.
> 
> This patch does the following:
> 
> * Completes the channel masquerade on a successful pickup before the application returns.  The channel is now guaranteed a zombie and must not continue executing the dialplan.
> 
> * Changes the return value of the directed pickup applications to return zero if the pickup failed and nonzero(-1) if the pickup succeeded.
> 
> * Made some code optimizations that no longer require re-checking the pickup channel to see if it is still available to pickup.
> 
> 
> This addresses bug 19310.
>     https://issues.asterisk.org/view.php?id=19310
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_directed_pickup.c 319648 
>   /branches/1.8/main/features.c 319648 
> 
> Diff: https://reviewboard.asterisk.org/r/1221/diff
> 
> 
> Testing
> -------
> 
> Did some quick tests to verify that pickup still works.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110518/43219dfc/attachment.htm>