[asterisk-dev] [Code Review] Crash when using directed pickup applications.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1221/
-----------------------------------------------------------

(Updated 2011-05-18 16:24:16.833721)


Review request for Asterisk Developers and Alec Davis.


Changes
-------

Added missing pickupsound presence test.  Good catch.


Summary
-------

The directed pickup applications can cause a crash if the pickup was successful because the dialplan keeps executing.

This patch does the following:

* Completes the channel masquerade on a successful pickup before the application returns.  The channel is now guaranteed a zombie and must not continue executing the dialplan.

* Changes the return value of the directed pickup applications to return zero if the pickup failed and nonzero(-1) if the pickup succeeded.

* Made some code optimizations that no longer require re-checking the pickup channel to see if it is still available to pickup.


This addresses bug 19310.
    https://issues.asterisk.org/view.php?id=19310


Diffs (updated)
-----

  /branches/1.8/apps/app_directed_pickup.c 319648 
  /branches/1.8/main/features.c 319648 

Diff: https://reviewboard.asterisk.org/r/1221/diff


Testing
-------

Did some quick tests to verify that pickup still works.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110518/52bf4717/attachment.htm>