[asterisk-dev] [Code Review] app_pickup: implement ${PICKUPRESULT} for dialplan related pickups

irroot reviewboard at asterisk.org
Wed May 18 01:53:20 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1217/#review3564
-----------------------------------------------------------


Seems good may i sugest a 0/1 return to make it more friendly to process in the dialplan ??



- irroot


On 2011-05-14 04:50:35, Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1217/
> -----------------------------------------------------------
> 
> (Updated 2011-05-14 04:50:35)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> app_directed_pickup failed to report back to dialplan success or failure of pickup.
> Which then meant the dialplan writer was unable to determine whether further action was required.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_directed_pickup.c 318867 
> 
> Diff: https://reviewboard.asterisk.org/r/1217/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110518/5bc864fc/attachment-0001.htm>


More information about the asterisk-dev mailing list