[asterisk-dev] [Code Review] Unlink a peer from the peers_by_ip table when expiring a registration

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1218/#review3558
-----------------------------------------------------------

Ship it!


Great catch, one comment.


/branches/1.6.2/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1218/#comment7237>

    !ast_sockaddr_isnull(&peer->addr)


- David


On 2011-05-16 12:32:56, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1218/
> -----------------------------------------------------------
> 
> (Updated 2011-05-16 12:32:56)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> If we aren't self-destructing a temp_peer, we still need to unlink the peer from the peers_by_ip table, otherwise we end up with multiple copies hanging around each time a registration expires and the peer re-registers.
> 
> 
> Diffs
> -----
> 
>   /branches/1.6.2/channels/chan_sip.c 319199 
> 
> Diff: https://reviewboard.asterisk.org/r/1218/diff
> 
> 
> Testing
> -------
> 
> Registered and let the registration expire multiple times and saw that "sip show objects" no longer had multiple copies of the same peer in peers_by_ip.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110516/a29bce9b/attachment.htm>