[asterisk-dev] [Code Review] Set T38 State To UNAVAILABLE when we could not negotiate T38

[Matthew Nicholson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1115/#review3556
-----------------------------------------------------------

Ship it!


This change should only be applied to trunk since it may alter the behavior of applications that depend on the t38_state values.  The CHANGES file needs to be updated to reflect the new use of the T38_STATE_REJECTED state.  Also res_fax should inspected and updated if necessary to accommodate the new behavior.

- Matthew


On 2011-05-13 06:01:17, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1115/
> -----------------------------------------------------------
> 
> (Updated 2011-05-13 06:01:17)
> 
> 
> Review request for Asterisk Developers and Matthew Nicholson.
> 
> 
> Summary
> -------
> 
> When a error in T.38 negotiation happens or its rejected on a channel the
> state of the channel reverts to unknown this should be unavailable.
> 
> this is important for negotiating T.38 gateway see 0013405
> 
> This patch adds a option T38_REJECTED that behaves as T38_DISABLED except it reports state unavailable when asked. 
> 
> 
> This addresses bug 18889.
>     https://issues.asterisk.org/view.php?id=18889
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 318105 
>   /trunk/channels/sip/include/sip.h 318105 
> 
> Diff: https://reviewboard.asterisk.org/r/1115/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110516/726279de/attachment-0001.htm>