[asterisk-dev] [Code Review] SIP: peer matching by callbackextension

[Nic Colledge]

Hi,

Is it possible to get this on the roadmap for 1.8.5 / 1.8.6 or is this only for Trunk?

Thanks,
Nic.

From: asterisk-dev-bounces at lists.digium.com [mailto:asterisk-dev-bounces at lists.digium.com] On Behalf Of Russell Bryant
Sent: 05 May 2011 20:39
To: David Vossel; Russell Bryant; Asterisk Developers
Subject: Re: [asterisk-dev] [Code Review] SIP: peer matching by callbackextension

This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/344/



Ship it!

It's optional, off by default, and multiple people seem to want this and find it useful.  It's fine with me.


- Russell


On December 9th, 2010, 12:16 p.m., David Vossel wrote:
Review request for Asterisk Developers.
By David Vossel.

Updated 2010-12-09 12:16:42

Description

If there are a number of peers with different callbackextension parameters and the same host address.  The first peer found matching the address is used regardless if that peer's callbackextension matches the incoming extension or not.



Now, to better match peers with incoming calls, if an incoming call's address can match multiple peers by address, we check each of those peer's callbackextension against the incoming extension for the best possible match.



It is possible that my implementation may be too expensive and only serve to address a minor edge case in the usage of chan_sip.  I do not fully understand the impact my changes may have upon performance when a large number of peers are present.  This patch assumes the new parse_uri() change has been made.



-------------------------------------------

for example with two peers as follows

[trunk1]

host=sip.myitsp.com

callbackextension=9991

...

[trunk2]

host=sip.myitsp.com

callbackextension=9992

...



incoming calls to 9991 and to 9992 are both matched to the peer trunk1

--------------------------------------------


Testing

Tested multiple peers with the same address containing different callbackextensions. Verified the correct peers were matched with incoming calls.

Bugs: 14340<https://issues.asterisk.org/view.php?id=14340>
Diffs

  *   /trunk/channels/chan_sip.c (297950)
  *   /trunk/channels/sip/include/sip.h (297950)
  *   /trunk/configs/sip.conf.sample (297950)

View Diff<https://reviewboard.asterisk.org/r/344/diff/>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110513/620f8c8f/attachment.htm>