[asterisk-dev] [Code Review] SIP user fields are crazy. Repeat extension searches if they all fail and semicolons are obfuscating the extension in the uri.

[David Vossel]

----- Original Message -----
> From: "Leif Madsen" <leif.madsen at asteriskdocs.org>
> To: asterisk-dev at lists.digium.com
> Sent: Thursday, May 12, 2011 1:18:02 PM
> Subject: Re: [asterisk-dev] [Code Review] SIP user fields are crazy. Repeat extension searches if they all fail and
> semicolons are obfuscating the extension in the uri.
> On 11-05-12 01:52 PM, David Vossel wrote:
> > For those people who have devices that do this to the user field and
> > they don't want it there, lets just make a sip.conf option that
> > strips those values out entirely out of every URI so their devices
> > work. No storing of the values in channel variables or anything like
> > that to complicated it. Just strip them off and let pattern matching
> > do its thing without them. If my understanding is correct, that is
> > all people really want that are having interoperability issues with
> > these user field options.
> >
> > I'd imagine the option would look like this.
> >
> > strip_uri_user_options = yes ; When this option is enabled any parts
> > of the user field of a URI delimited by a ';' will be stripped off
> > before extensions or peer pattern matching occurs. This option is
> > purely for interoperability purposes for devices that put options in
> > the user field that are not supposed to be used during pattern
> > matching.
> >
> > If someone doesn't what those undefined fields stripped off their
> > user fields, then they don't enable the option and have to do
> > dialplan magic to get the extension to match correctly.
> >
> > Does this work for everyone? I know there is more to discuss here,
> > but this approach seems to have merit regardless of what other
> > changes in this area may be introduced in the future.
> 
> I could get behind this idea. It should be disabled by default.
> 
> Does this go into 1.8 as a "feature that fixes a bug"?
> 
> Leif.
> 
> --

Yes, this is an interop issue.  Anything that makes us work with stuff at this sort of level should be considered a fix in my opinion.

I agree with the option being off by default as well since this is not a standards based thing.

-- 
David Vossel
Digium, Inc. | Software Developer, Open Source Software
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: www.digium.com & www.asterisk.org
The_Boy_Wonder in #asterisk-dev