[asterisk-dev] [Code Review] app_voicemail appending IMAPFOLDER to 'vm-' to create filename for prompt to play.

[jrose]

> On 2011-05-12 13:28:17, jrose wrote:
> > /branches/1.8/apps/app_voicemail.c, line 6716
> > <https://reviewboard.asterisk.org/r/1215/diff/1/?file=16489#file16489line6716>
> >
> >     Alright, I just realized that this is rather wrong actually and should instead just search for an allowable format.  I'll have to look into how to specify that.

For now I'll just set argument 2 to null.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1215/#review3538
-----------------------------------------------------------


On 2011-05-12 13:27:00, jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1215/
> -----------------------------------------------------------
> 
> (Updated 2011-05-12 13:27:00)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and David Vossel.
> 
> 
> Summary
> -------
> 
> If you specify an imap folder in voicemail.conf, the name of the inbox gets overwritten by the imap folder.  This is necessary for actually communicating with the imap server.  However, when we are generating the file names for Allison saying the names of the folders, it messes with that too.  Without adding extra files, this will generally result in the file not being found, which for some interesting reason means we'll automatically hang up the channel.
> 
> In order to fix this, I just intercepted the for loop if the index was 0 (meaning imapfolder/INBOX), checked to see if the imapfolder file name exists, if it does, it uses that, if it doesn't, it just uses the default sound name of vm-INBOX.
> 
> Also, it should be noted that I still need to document how it works, which is something I'm guessing I should just do in the voicemail.conf sample.
> 
> 
> This addresses bug 16104.
>     https://issues.asterisk.org/view.php?id=16104
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_voicemail.c 317718 
> 
> Diff: https://reviewboard.asterisk.org/r/1215/diff
> 
> 
> Testing
> -------
> 
> Rudimentary test with gmail imap server, some various folders and some that even have heirarchy.  Tested with and without the sound file being in the expected location.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110512/b89670bc/attachment.htm>