[asterisk-dev] [Code Review] chan_sip refcount cleanup derived from twilsons's review 1207

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1210/#review3510
-----------------------------------------------------------



/tags/1.8.3.3/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1210/#comment7183>

    Since this function is just returning 0 every time regardless of other circumstances, couldn't it just be a void function instead?


- jrose


On 2011-05-09 16:40:49, Rob Gagnon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1210/
> -----------------------------------------------------------
> 
> (Updated 2011-05-09 16:40:49)
> 
> 
> Review request for Asterisk Developers, Terry Wilson, David Vossel, and Rob Gagnon.
> 
> 
> Summary
> -------
> 
> This patch is the altered version of Terry's patch for chan_sip from review 1207 (which was for branch 1.6.2)
> 
> This patch is for tag 1.8.3.3, which should apply pretty clean to trunk and to branch 1.8
> 
> 5 alterations were done to fit the 1.8 version of chan_sip.c.  The other 21 hunks applied either with simple offsets, or fuzz 1/2.
> 
> 1) a. remove peer_is_marked() function
>    b. move unlink_marked_peers_from_tables()
>    c. move unlink_peer_from_tables()
> 
> 2) manual patch of the code in sip_cancel_destroy() 
> 
> 3) find_call() did not need <<< p = dialog_unref(p, "pedantic linear search for dialog unref to restart search"); >>> due to the new iterator in place of the original goto loop.
> 
> 4) changed the comment from "/* returns p locked and ref'd */" to "/* returns p ref'd */"
> 
> 5) manunal patch of the code in start_session_timer()
> 
> 
> This addresses bug 17255.
>     https://issues.asterisk.org/view.php?id=17255
> 
> 
> Diffs
> -----
> 
>   /tags/1.8.3.3/channels/chan_sip.c 318283 
> 
> Diff: https://reviewboard.asterisk.org/r/1210/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rob
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110509/eeb002b9/attachment-0001.htm>