[asterisk-dev] [Code Review] ParkedCall can now be 'exten at parkinglot' instead of just 'exten'

[jrose]

> On 2011-05-06 16:39:20, David Vossel wrote:
> > /trunk/main/features.c, line 4501
> > <https://reviewboard.asterisk.org/r/1209/diff/1/?file=16375#file16375line4501>
> >
> >     make this
> >     
> >     const char *

Done.


> On 2011-05-06 16:39:20, David Vossel wrote:
> > /trunk/main/features.c, line 4504
> > <https://reviewboard.asterisk.org/r/1209/diff/1/?file=16375#file16375line4504>
> >
> >     sscanf is a preferred method of converting strings to integers, longs, etc.  It allows you to specify the signedness of a variable if that is important and also detect a failure.
> >     
> >     This works though.

Changed.  I used...

sscanf(data, "%d", &park);

And that works and I'm pretty sure that is right, so I'm going to go ahead and shippppit.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1209/#review3496
-----------------------------------------------------------


On 2011-05-06 09:12:12, jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1209/
> -----------------------------------------------------------
> 
> (Updated 2011-05-06 09:12:12)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This feature addition allows the ParkedCall application to include the name of a parkinglot so that the caller can use this application on a specific parkinglot rather than just jumping to whichever parkinglot is already bound to the requesting channel.
> 
> 
> This addresses bug 18777.
>     https://issues.asterisk.org/view.php?id=18777
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 317381 
>   /trunk/main/features.c 317381 
> 
> Diff: https://reviewboard.asterisk.org/r/1209/diff
> 
> 
> Testing
> -------
> 
> Tested with multiple parkinglots of various names to make sure it searches the right parkinglots (parkinglot names have to be used, not their context names).  Also tested to make sure it didn't interfere with the normal behavior with no specified parkinglot (it was segfaulting, for what was an obvious reason, so testing was useful).
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110509/588003fc/attachment.htm>