[asterisk-dev] [Code Review] OOH323 does not do full T.38 Handshaking / Fax Detection is limited

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1174/#review3501
-----------------------------------------------------------


peer review


/trunk/addons/chan_ooh323.c
<https://reviewboard.asterisk.org/r/1174/#comment7170>

    red blob



/trunk/addons/chan_ooh323.c
<https://reviewboard.asterisk.org/r/1174/#comment7171>

    same



/trunk/addons/chan_ooh323.c
<https://reviewboard.asterisk.org/r/1174/#comment7172>

    same



/trunk/addons/chan_ooh323.c
<https://reviewboard.asterisk.org/r/1174/#comment7173>

    same



/trunk/addons/chan_ooh323.c
<https://reviewboard.asterisk.org/r/1174/#comment7174>

    same



/trunk/addons/chan_ooh323.c
<https://reviewboard.asterisk.org/r/1174/#comment7175>

    same



/trunk/addons/chan_ooh323.c
<https://reviewboard.asterisk.org/r/1174/#comment7176>

    same



/trunk/addons/chan_ooh323.c
<https://reviewboard.asterisk.org/r/1174/#comment7177>

    same



/trunk/addons/chan_ooh323.c
<https://reviewboard.asterisk.org/r/1174/#comment7178>

    braces for if statements


- Paul


On 2011-05-09 01:07:22, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1174/
> -----------------------------------------------------------
> 
> (Updated 2011-05-09 01:07:22)
> 
> 
> Review request for Asterisk Developers and may213.
> 
> 
> Summary
> -------
> 
> Im working on full handshaking for this driver and correct fax detection.
> 
> OOH323 <-> receive fax does not handshake / detect Fax/T38
> 
> Watch this space for updates
> 
> This fits in with the T.38 Integration im working on.
> 
> 
> This addresses bug 19183.
>     https://issues.asterisk.org/view.php?id=19183
> 
> 
> Diffs
> -----
> 
>   /trunk/addons/chan_ooh323.c 318105 
> 
> Diff: https://reviewboard.asterisk.org/r/1174/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110509/714bcc8d/attachment.htm>